Skip to content
This repository has been archived by the owner on Jan 25, 2025. It is now read-only.

Revamped Keyspace settings to match Android 13 AOSP settings #53

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

0x4f53
Copy link
Member

@0x4f53 0x4f53 commented Jan 29, 2023

♻️ Current situation

The Keyspace settings menu UI seemed like a mix of Material 1.0, Material 2.0 and Material 3.0. It needs to be update to match the design language of the rest of the app.

💡 Proposed solution

Update Keyspace settings using AOSP system settings as reference.

📷 Screenshots

Old New
Old Keyspace settings New Keyspace settings

📚 Release Notes

  • Added a back button to the top right corner of the screen
  • Updated Keyspace settings using AOSP system settings as reference.
  • Made text bigger and increased margin in several places

📝 Testing

  • Tap the back button on the top right to go back. This behavior is identical to tapping a navigation bar button on the bottom or swiping from left or right edge of the screen to go back.

@0x4f53 0x4f53 changed the base branch from main to v1.4.2 January 29, 2023 18:38
@0x4f53 0x4f53 changed the title made settings UI match Android 13 spec even more Revamped Keyspace settings to match AOSP settings Jan 29, 2023
@0x4f53 0x4f53 changed the title Revamped Keyspace settings to match AOSP settings Revamped Keyspace settings to match Android 13 AOSP settings Jan 29, 2023
@rohan-chaturvedi rohan-chaturvedi requested review from nimish-ks and rohan-chaturvedi and removed request for nimish-ks February 1, 2023 07:48
Copy link
Member

@rohan-chaturvedi rohan-chaturvedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small copy suggestion

@0x4f53 0x4f53 merged commit 40f730b into v1.4.2 Feb 1, 2023
@0x4f53 0x4f53 deleted the settings_ui_updates branch February 1, 2023 23:51
@rohan-chaturvedi rohan-chaturvedi mentioned this pull request Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants